Skip to content
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
c55cf2d
Run nessus script installation daily, not hourly
brucehoff Nov 7, 2024
da1dfef
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Nov 14, 2024
5b04ff6
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Nov 16, 2024
3b977ee
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Dec 18, 2024
7eba7ec
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Dec 19, 2024
2a39c53
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Jan 9, 2025
ddc45d7
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Jan 16, 2025
dedce36
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Jan 25, 2025
81c6261
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Mar 8, 2025
0bb1257
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Apr 5, 2025
e3e4379
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Apr 24, 2025
ef16296
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff May 8, 2025
e968c04
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff May 15, 2025
2425330
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Jun 5, 2025
88f9cc9
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Jul 1, 2025
6b52705
Merge remote-tracking branch 'upstream/master'
brucehoff Jul 9, 2025
89fad2d
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Jul 9, 2025
73fcb5c
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Jul 11, 2025
43f17dc
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Jul 28, 2025
c2f44d1
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Aug 13, 2025
c35cf31
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Aug 25, 2025
1ee5012
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Aug 25, 2025
f36f051
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Aug 26, 2025
5f185ef
Merge branch 'master' of https://github.com/Sage-Bionetworks-IT/organ…
brucehoff Sep 16, 2025
f81ef23
PLFM-9092: OIDC integration allowing developer forks of Synapse repo …
brucehoff Sep 16, 2025
0b05b58
merge upstream
brucehoff Dec 2, 2025
6754dee
PLFM-9253: Allow code pipeline roles to access synapse dev KMS key
brucehoff Dec 2, 2025
3e4880a
PLFM-9253: Allow code pipeline roles to access synapse dev KMS key
brucehoff Dec 2, 2025
146cad8
PLFM-9253: update description of CMK policy statements
brucehoff Dec 2, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions org-formation/650-identity-providers/_tasks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,9 @@ GithubOidcSageBionetworksSynapseBuild:
- owner: "Sage-Bionetworks"
name: "Synapse-Repository-Services"
branches: ["*"]
- owner: "Sage-Bionetworks"
name: "Synapse-Stack-Builder"
branches: ["develop"]
- owner: "brucehoff"
name: "Synapse-Repository-Services"
branches: ["*"]
Expand Down
19 changes: 4 additions & 15 deletions sceptre/synapsedev/templates/SynapseCMK-template.json
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,9 @@
{ "Fn::ImportValue": "us-east-1-accounts-AWSIAMAdminRoleArn" },
{ "Fn::GetAtt": [ "SynapseDeploymentRole", "Arn" ] },
{ "Fn::Sub": "arn:aws:iam::${AWS::AccountId}:role/sagebase-github-oidc-sage-bionetworks-it" },
{ "Fn::Sub": "arn:aws:iam::${AWS::AccountId}:role/aws-reserved/sso.amazonaws.com/AWSReservedSSO_Administrator_693a85eb20cd5043" }
{ "Fn::Sub": "arn:aws:iam::${AWS::AccountId}:role/aws-reserved/sso.amazonaws.com/AWSReservedSSO_Administrator_693a85eb20cd5043" },
{ "Fn::Sub": "arn:aws:iam::${AWS::AccountId}:role/Synapse-Build-*-CodeBuildServiceRole" },
{ "Fn::Sub": "arn:aws:iam::${AWS::AccountId}:role/Deployment-Pipeline-CodeBuildServiceRole" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really needed?

]
}
}
Expand All @@ -334,20 +336,7 @@
"Sid": "Allow root administration of the key",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: This statement is more expansive than just root administration, can you update the description?

"Effect": "Allow",
"Principal": {
"AWS": [
{
"Fn::GetAtt": [
"SynapseDeploymentRole",
"Arn"
]
},
{
"Fn::ImportValue": "us-east-1-accounts-AWSIAMAdminRoleArn"
},
{ "Fn::Sub": "arn:aws:iam::${AWS::AccountId}:root" },
{ "Fn::Sub": "arn:aws:iam::${AWS::AccountId}:role/sagebase-github-oidc-sage-bionetworks-it" },
{ "Fn::Sub": "arn:aws:iam::${AWS::AccountId}:role/aws-reserved/sso.amazonaws.com/AWSReservedSSO_Administrator_693a85eb20cd5043" }
]
"AWS": "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being changed to *? Is there something preventing us from maintaining least privilege?

Copy link
Contributor Author

@brucehoff brucehoff Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question: In this policy the 'allow' and 'deny' sections have the same list of IAM entities, creating unnecessary duplication. By simplifying the 'allow' to '*' and leaving the 'deny' in place, we get the same level of 'least privilege' while simplifying the policy document. This begs the question, "why not keep the 'allow' and eliminate the 'deny' part of the policy?" The reason is because the 'deny' section allows the use of wildcards and we need to use the pattern, Synapse-Build-*-CodeBuildServiceRole.

},
"Action": [
"kms:*"
Expand Down