-
Notifications
You must be signed in to change notification settings - Fork 3
[IT-4417] Build multi-platform docker images #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Build images for both amd64 and arm64 to support Graviton EC2 instances. https://docs.docker.com/build/ci/github-actions/multi-platform/
d8e1479 to
4750f83
Compare
brucehoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the build may not pass due to failed vulnerability checks, and fixing the problem may depend on these issues being completed:
https://sagebionetworks.jira.com/browse/SYNPY-1735
https://sagebionetworks.jira.com/browse/SYNR-1566
924d732 to
89bec38
Compare
zaro0508
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. is this related to an issue? if so, can you reference in the PR's title?
zaro0508
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like testing failed
Relying on build cache to rebuild won't work. Instead pass intermediate artifacts around. This has the added benefit of tagging and pushing the same image that Trivy scanned, instead of rebuilding a new image.
Build images for both amd64 and arm64 to support Graviton EC2 instances.
https://docs.docker.com/build/ci/github-actions/multi-platform/