Skip to content

[DPE-1423] Swap ocean-aws-k8s module to support provided commit #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BryanFauble merged 3 commits into from
Sep 4, 2025
Merged

[DPE-1423] Swap ocean-aws-k8s module to support provided commit #72

BryanFauble merged 3 commits into from
Sep 4, 2025

Conversation

@BryanFauble
Copy link
Contributor

@BryanFauble BryanFauble commented Aug 11, 2025

Problem:

  • 1.33 broke the Spotinst terraform module as the filter used is no longer valid for AWS published images

Solution:

  • Use the commit hash provided by support

Testing:

  • Update source and point the stack to use the local version instead of one from the private module registery

@spacelift-int-sagebionetworks spacelift-int-sagebionetworks bot temporarily deployed to spacelift/dpe-dev-kubernetes-deployments August 11, 2025 14:21 Inactive
@linglp linglp mentioned this pull request Aug 11, 2025
Draft
thomasyu888
thomasyu888 approved these changes Aug 11, 2025
View reviewed changes
Copy link
Contributor

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BryanFauble BryanFauble marked this pull request as ready for review September 4, 2025 17:03
@BryanFauble BryanFauble requested a review from a team as a code owner September 4, 2025 17:03
@BryanFauble BryanFauble merged commit b07620f into main Sep 4, 2025
6 checks passed
@BryanFauble BryanFauble deleted the dpe-1423-upgrade-k8s branch September 4, 2025 17:04
BryanFauble added a commit that referenced this pull request Sep 4, 2025
@BryanFauble
[DPE-1423] Swap ocean-aws-k8s module to support provided commit (#72)
3237b5c 
* Swap to the new published module for ocean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasyu888 thomasyu888 thomasyu888 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BryanFauble @thomasyu888