-
Notifications
You must be signed in to change notification settings - Fork 2
Fix broken schema references preventing Seqera Platform launch #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…fig, fix allOf references Co-authored-by: adamjtaylor <[email protected]>
Co-authored-by: adamjtaylor <[email protected]>
|
@copilot nextflow_schema.json:61-65 |
Co-authored-by: adamjtaylor <[email protected]>
adamjtaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nice job @copilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes critical structural errors in nextflow_schema.json that were preventing the Seqera Platform from correctly parsing the pipeline launch form.
Changes:
- Corrected the typo in the definition key from "miniatue_options" to "miniature_options"
- Fixed broken schema references in the
allOfsection to point to existing definitions - Added a description for the
n_componentsparameter
Comments suppressed due to low confidence (2)
nextflow_schema.json:41
- Corrected spelling of 'thumbnauls' to 'thumbnails'.
"description": "The pyramid level used in thumbnauls, Default: -1 (smallest)",
nextflow_schema.json:52
- Corrected spelling of 'compatiable' to 'compatible'.
"description": "The colormap used. Ensure colormap is compatiable with `n_components` selected ",
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot we do need to fix nextflow_schema.json:41 Corrected spelling of 'thumbnauls' to 'thumbnails'. Corrected spelling of 'compatiable' to 'compatible'. |
Co-authored-by: adamjtaylor <[email protected]>
|
Confirming that this unblocks launch on Seqera Platform Version 25.1.5_5197cfa as deployed at Sage as of today. |
Co-authored-by: adamjtaylor <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: adamjtaylor <[email protected]>
…tional-save-for-images Feature merge into branch to unblock rapidly
|
is there documentation about how to use the dev environment? |
Co-authored-by: adamjtaylor <[email protected]>
The
nextflow_schema.jsoncontained structural errors causing Seqera Platform to reject valid parameters with "One or more fields contain invalid values."Changes
miniatue_options→miniature_optionsallOfsection now correctly references existing definitions instead of non-existent#/definitions/parametersn_componentsparameterBefore/After
Schema now validates correctly and renders all parameter groups in the Seqera Platform launch form.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.