Add H5AD as file type. #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasyu888
reviewed
Sep 4, 2025
andrewelamb
commented
Sep 4, 2025
thomasyu888
reviewed
Sep 4, 2025
Contributor
thomasyu888
left a comment
thomasyu888
left a comment
There was a problem hiding this comment.
🔥 LGTM! I'll defer to @jaymedina / @adamjtaylor / Aditi for a review of this. I'll link Aditi this PR in a DM
|
andrewelamb
commented
Sep 5, 2025
| file_type = FileType.get_file_type("HDF5") | ||
|
|
||
|
|
||
| class H5ADSuite(HDF5Suite): |
Contributor
Author
There was a problem hiding this comment.
H5ADSuite inherits from HDF5Suite as per Jennifer Altreuter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DPE-1444
Problem:
H5ADis currently an extension under theHDF5file type. It is needed as a distinct file type, so thatH5ADspecific tests can be added in the very near future.Solution:
H5ADis now a distinct file type..h5adhas been removed fromHDF5as an extension.Testing:
An
H5ADfile was added, and theqc_filecommand is run with it as a test.