Skip to content

Conversation

@rxu17
Copy link
Contributor

@rxu17 rxu17 commented Jan 27, 2025

Purpose: This PR will be a hotfix to filter out germline variants from the sv file at the consortium release step (and subsequently the public release step since it just copies over the consortium release sv file) before we can release the germline variant validation rule.

Changes: Changes are isolated to the store_sv_files function in database_to_staging.py. Had to make it case-insensitive because I've found that SV_STATUS is in the testing pipeline's consortium release sv file while SV_Status is found in the production pipeline 's consortium release sv file.

Testing: Followed the standard validation of new features guide. The germline variants are filtered out.

@rxu17 rxu17 requested a review from a team as a code owner January 27, 2025 18:10
@sonarqubecloud
Copy link

Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM. will defer to @danlu1 for final review.

Copy link
Contributor

@danlu1 danlu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danlu1
Copy link
Contributor

danlu1 commented Jan 31, 2025

@rxu17 just a follow up question, since you found "SV_STATUS is in the testing pipeline's consortium release sv file while SV_Status is found in the production pipeline 's consortium release sv file.". Do we have plan to update testing pipeline to make it align with prod?

@rxu17
Copy link
Contributor Author

rxu17 commented Jan 31, 2025

@rxu17 just a follow up question, since you found "SV_STATUS is in the testing pipeline's consortium release sv file while SV_Status is found in the production pipeline 's consortium release sv file.". Do we have plan to update testing pipeline to make it align with prod?

I think this is another ticket to figure out why it's happening and then resolve from there (because I'm not sure why it's happening). I think that's a low priority ticket given we have no known current issues. Overarching goal to resolve this would be having a data validation framework set up since we're not enforcing any specific data standards and checks in the release files.

@rxu17 rxu17 merged commit de2909b into main Jan 31, 2025
13 checks passed
@rxu17 rxu17 deleted the gen-1704-filter-out-germline branch January 31, 2025 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants