[GEN-1821] Provide genie user-agent string to synapse python client to track usage #610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxu17
reviewed
Sep 5, 2025
rxu17
approved these changes
Sep 5, 2025
Contributor
rxu17
left a comment
rxu17
left a comment
There was a problem hiding this comment.
LGTM! Once everything passes including integration tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We would like to track sites/other user’s aacrgenie usage but right now there is no user_agent information being specified in the package.
Solution:
Utilize the new functionalities from syanapseclient 4.8.0 to add
user_agentwhen initiating Synapse objectTesting:
Tested that user_agent information is added successfully when synapseclient is 4.9.0.
