-
Couldn't load subscription status.
- Fork 9
[GEN-2230] refactor update table function #616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this feature, I just had some comments
|



Problem:
The original
load.store_databasewhich is used in table update utilize:These can be addressed easily in the
store_rowsanddelete_rowsas we upgraded synapseclient version.The docstring of
_create_update_rowsdfis not clear enought.Solution:
load.store_databaseto update/append rows usingstore_rowsand delete rows usingdelete_rows._create_update_rowsdf.Testing:(wip)