Skip to content

Conversation

@danlu1
Copy link
Contributor

@danlu1 danlu1 commented Oct 23, 2025

Problem:

The original load.store_database which is used in table update utilize:

  1. A temporary file to append, update, and delete rows.
  2. Manually convert float value to integer.
    These can be addressed easily in the store_rows and delete_rows as we upgraded synapseclient version.

The docstring of _create_update_rowsdf is not clear enought.

Solution:

  1. Refactored load.store_database to update/append rows using store_rows and delete rows using delete_rows.
  2. Updated docstring of _create_update_rowsdf.

Testing:(wip)

  1. Unit test suites have been added.
  2. Integration test passed. See https://sagebionetworks.jira.com/browse/GEN-2230 for details.

@danlu1 danlu1 requested a review from a team as a code owner October 23, 2025 01:15
Copy link
Contributor

@rxu17 rxu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this feature, I just had some comments

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants