[GEN-2326] Centralize where error reports get saved in Genie #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thomasyu888
reviewed
Dec 15, 2025
Member
thomasyu888
left a comment
thomasyu888
left a comment
There was a problem hiding this comment.
🔥 LGTM, but i'll defer to @danlu1 for final review
thomasyu888
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Originally, our validation error reports for sites were being saved to their center's staging folders. This is not a very intuitive place to save it as the validation step of the pipeline is earlier in the pipeline compared to staging which is later.
Solution:
Our maf error reports get saved to an
errorsfolder, we should have validation errors saved to that folder as well. We should also name the report as_validation_errors.txtinstead of_errors.txtso it's clear what errors these areTesting:
Validation errors are saved successfully:
