Skip to content

Conversation

@xschildw
Copy link
Contributor

No description provided.

@xschildw xschildw requested a review from Copilot January 19, 2026 21:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the codebase from AWS SDK v1 to AWS SDK v2 for S3 operations. The migration includes updating API calls, removing deprecated transfer manager implementations, and updating dependencies. The storage class enum values are also updated to match SDK v2 conventions (e.g., IntelligentTieringINTELLIGENT_TIERING).

Changes:

  • Migrated all S3 client usage from AmazonS3 (v1) to S3Client (v2) with updated API methods
  • Removed S3 transfer manager classes and replaced with native SDK v2 operations
  • Updated storage class enum values to SDK v2 naming conventions (uppercase with underscores)

Reviewed changes

Copilot reviewed 35 out of 36 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pom.xml Removed v1 S3 SDK dependency, added v2 S3 dependency
TemplateGuiceModule.java Updated provider methods for SDK v2 S3 client, fixed typo in method name
S3BucketBuilderImpl.java Migrated to SDK v2 S3 APIs, updated all S3 operations including encryption, lifecycle, inventory, notifications
S3BucketClassTransition.java Changed storage class type from v1 to v2 enum
S3ConfigValidator.java Updated storage class type, added inline event validation
CloudFormationClientWrapperImpl.java Migrated S3 operations to SDK v2, fixed typo in javadoc
SecretBuilderImpl.java Updated S3 upload to use SDK v2 RequestBody
ArtifactCopyImpl.java Migrated to SDK v2 with HeadObject check and Path-based uploads
BedrockAgentContextProvider.java Updated S3 putObject to use RequestBody
BedrockGridAgentContextProvider.java Updated S3 putObject to use RequestBody
MarkDownItLambdaBuilderImpl.java Updated S3 upload to use Path-based API
SynapseDocsBuilderImpl.java Replaced transfer manager with SDK v2 copy/delete operations, implemented pagination
DataWarehouseBuilderImpl.java Updated zip upload to use RequestBody
BackfillDataWarehouseBuilderImpl.java Updated zip upload with improved error handling
ArtifactDownloadImpl.java Added stream and bytes download methods
S3TransferManager*.java Removed deprecated transfer manager classes
s3-buckets-config.json Updated storage class values to uppercase convention
Test files Updated all tests to mock SDK v2 S3 APIs

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@xschildw xschildw marked this pull request as ready for review January 19, 2026 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant