-
Couldn't load subscription status.
- Fork 15
feat(model-ad): add tooltips and sort tooltips to comparison tool column headers (MG-429) #3600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallieswan
commented
Oct 23, 2025
...rers/comparison-tools/src/lib/base-comparison-tool/base-comparison-tool.component.stories.ts
Show resolved
Hide resolved
hallieswan
commented
Oct 23, 2025
...lorers/comparison-tools/src/lib/comparison-tool-columns/comparison-tool-columns.component.ts
Show resolved
Hide resolved
…ests, set default sort
…visibility, update column selector to not display primary column
5113e6f to
dd7e8b1
Compare
hallieswan
commented
Oct 27, 2025
...tool-controls/comparison-tool-column-selector/comparison-tool-column-selector.component.html
Outdated
Show resolved
Hide resolved
hallieswan
commented
Oct 27, 2025
hallieswan
commented
Oct 27, 2025
hallieswan
commented
Oct 27, 2025
hallieswan
commented
Oct 27, 2025
hallieswan
commented
Oct 27, 2025
hallieswan
commented
Oct 27, 2025
...tool-controls/comparison-tool-column-selector/comparison-tool-column-selector.component.html
Show resolved
Hide resolved
sagely1
approved these changes
Oct 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds tooltips and sort tooltips to comparison tool column headers.
Note
Until the ui_config is updated in the next data release, the Model-AD CT sort icons will not update when the sort button is clicked in the column header. This functionality can be previewed in the base-comparison-tool story.
Related Issue
MG-429
Changelog
Preview
nx storybook explorers-storybookSort:
MG-429_sort.mp4
Column visibility based on column selector:
MG-429_column_selectors.mp4
model-ad-build-images && model-ad-docker-startMG-429_tooltips.mp4