Skip to content

Conversation

@sagely1
Copy link
Contributor

@sagely1 sagely1 commented Oct 25, 2025

Description

Adds http error interceptor to handle errors. Rollbar integration will be implemented in MG-230.
This PR also tweaks the styling for the ComparisonToolColumnSelectorComponent.

Related Issue

MG-466
MG-427

Changelog

  • Add HttpErrorInterceptor and display error toasts for errors
  • Fix styling for ComparisonToolColumnSelectorComponent

Preview

Sample error:
image

ComparisonToolSelectorComponent styling

Alignment before:
image

Alignment after:
image

@sagely1 sagely1 requested a review from a team as a code owner October 25, 2025 00:42
@sagely1 sagely1 changed the title feat(model-ad): add http error interceptor (MG-466, MG-427) feat(model-ad): add http error interceptor, column selector css fix (MG-466, MG-427) Oct 25, 2025
@sagely1 sagely1 requested a review from hallieswan October 25, 2025 00:54
Copy link
Collaborator

@hallieswan hallieswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple small questions

@sagely1 sagely1 requested a review from hallieswan October 27, 2025 23:06
@sagely1 sagely1 deployed to model-ad-pr October 27, 2025 23:10 — with GitHub Actions Active
Copy link
Collaborator

@hallieswan hallieswan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hallieswan hallieswan added this pull request to the merge queue Oct 27, 2025
Merged via the queue into Sage-Bionetworks:main with commit 477a267 Oct 27, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants