feat(agora): add structured logging and error handling across components (AG-1787)#3890
Open
sagely1 wants to merge 3 commits intoSage-Bionetworks:mainfrom
Open
feat(agora): add structured logging and error handling across components (AG-1787)#3890sagely1 wants to merge 3 commits intoSage-Bionetworks:mainfrom
sagely1 wants to merge 3 commits intoSage-Bionetworks:mainfrom
Conversation
…mponents - Make wikiParams a required input on wiki, popover-link, and modal-link components - Switch wiki component from effect-based to OnInit lifecycle for data fetching - Add isPlatformBrowser guard to wiki and terms-of-service components - Improve wiki/wiki-hero layout with flexbox for better loading state display - Convert wiki isLoading to signal for reactive state management - Add className input to wiki and wiki-hero components for external styling - Add heroBackgroundImagePath input to wiki-hero for customizable backgrounds - Fix logger service to not log undefined when optional data/error params are omitted - Add non-null assertion for optional headerTitleWikiParams in comparison-tool-header Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… shared components Remove the agora-specific about, news, and shared libraries that have been superseded by the explorers shared component library. Migrate all Agora components to use explorers equivalents for modal-link, popover-link, wiki, loading-icon, and svg-icon. - Delete libs/agora/about, libs/agora/news, libs/agora/shared - Delete SynapseApiService and SynapseWiki model (replaced by explorers equivalents) - Delete agora-specific popover-link component from genes library - Update all gene, comparison-tool, and nominated-target components to import from @sagebionetworks/explorers/util instead of @sagebionetworks/agora/shared - Route about/news pages through shared wiki-hero component - Add wiki-pages styles for about and news page content - Remove unused tsconfig path aliases - Update testing mocks to use explorers models Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add LoggerService and ErrorOverlayService to all Agora components for consistent error handling and observability via Sentry. - Add LoggerService logging to gene-details, gene-evidence-*, gene-similar, gene-comparison-tool, gene-soe-charts, nominated-targets, and teams - Add ErrorOverlayService.showError for user-visible error states - Add takeUntilDestroyed to all component subscriptions to prevent memory leaks - Add DestroyRef injection pattern for proper subscription cleanup - Add isPlatformBrowser guards where needed for SSR compatibility - Add LoggerService to Agora and Model-AD app components for version loading - Add missing OnDestroy cleanup for search-input debounce subject Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
sagely1
changed the title
sagely1
commented
Feb 21, 2026
| <div | ||
| class="gct-how-to-panel-pane active" | ||
| [ngClass]="{ active: activePane === i }" | ||
| [class.active]="activePane === i" |
Contributor
Author
There was a problem hiding this comment.
Standardizing on newer syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR standardizes logging and error handling. It specifically improves memory handling, SSR compatibility and logging.
Related Issues
AG-1787
Changelog
LoggerServiceandErrorOverlayServiceto all Agora components for consistent error handling and observability via SentrytakeUntilDestroyedto all component subscriptions to prevent memory leaksisPlatformBrowserguards where needed for SSR compatibilityOnDestroycleanup for search-input debounce subjectTest plan
[LOG]messages)