[SCHEMATIC-314] JSONSchema Data Model Documentation #1622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SageGJ
changed the title
thomasyu888
reviewed
Jun 23, 2025
Member
thomasyu888
left a comment
thomasyu888
left a comment
There was a problem hiding this comment.
🔥 LGTM! I'll leave it to @andrewelamb for the final review after other things get merged in
BryanFauble
reviewed
Jun 23, 2025
BryanFauble
reviewed
Jun 23, 2025
BryanFauble
reviewed
Jun 23, 2025
BryanFauble
reviewed
Jun 23, 2025
BryanFauble
reviewed
Jun 23, 2025
BryanFauble
reviewed
Jun 23, 2025
BryanFauble
approved these changes
Jun 23, 2025
Co-authored-by: BryanFauble <17128019+BryanFauble@users.noreply.github.com>
Collaborator
Author
|
@BryanFauble thanks for reviewing! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Users need documentation explaining how concepts in a data model map to fields in JSONSchema files.
Solution:
A new documentation page covering how fields in JSONSchema files are set from concepts in a schematic data model.
Testing:
Documentation (see here) will be reviewed by others and feedback will be given.