Skip to content

Conversation

@SageGJ
Copy link
Collaborator

@SageGJ SageGJ commented Jul 1, 2025

Problem:

  • There were appx 40 errors within our rst documentation pages related to namespace collisions and formatting
  • Section headers and hierarchy can be anything within sphinx, and hierarchy is determined by order of appearance. Thus, when having different conventions between files, it can be difficult to determine the type of section each section is by looking. This would also complicate configuring settings across the documentation as a whole since the same type of section can be indicated with different characters.
  • There also existed a number of broken links

Solution:

  • Unique section names were added where duplicates existeed
  • Section headers were all updated to follow the sphinx/python convention since we use sphinx.
  • Links were updated where appropriate.

Testing:

  • VSCode is showing no errors in the docs directory (see below)
  • Documentation pages were reviewed
    image

Reviewing Instructions

Please review the documentation and

  • test links within pages
  • give feedback on organization of information
  • content of the documentation was largely left unchanged, but if something could be clarified please point that out as well.

@SageGJ SageGJ marked this pull request as ready for review July 2, 2025 18:58
@SageGJ SageGJ requested a review from a team as a code owner July 2, 2025 18:58
@BryanFauble BryanFauble requested a review from Copilot July 2, 2025 19:16
@BryanFauble
Copy link
Member

For those reviewing here is a link to the rendered doc pages:
https://schematicpy--1624.org.readthedocs.build/en/1624/

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes section headings, updates reference links, and fixes formatting inconsistencies across multiple .rst files to align with the Sphinx/python conventions and resolve broken links.

  • Converted all section headings to use consistent adornment (e.g., #, *, =, ^, etc.).
  • Updated cross-reference targets and ref links to match defined labels.
  • Removed formatting errors and one duplicated paragraph.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
validation_rules.rst Standardized headings and increased :depth: in table of contents
tutorials.rst Applied uniform heading adornments for sections
troubleshooting.rst Added consistent heading markup for subsections
manifest_validation.rst Replaced underlines, updated ref links, but left one hyphen line
manifest_submission.rst Standardized headings and updated configuration ref link
manifest_generation.rst Unified heading styles and updated internal refs
linkml.rst Standardized headings; duplicated paragraph remains
jsonschema_generation.rst Corrected CLI ref targets to full cli_reference anchors
installation.rst Updated heading adornments and anchor links
index.rst Applied # adornment for main title
configuration.rst Converted heading levels to # for major sections
conf.py Added autosectionlabel_prefix_document = True
cli_reference.rst Standardized top-level heading; unified subcommand titles
asset_store.rst Aligned section headers with new style patterns
Comments suppressed due to low confidence (4)

docs/source/linkml.rst:10

  • This paragraph is duplicated back-to-back. Remove the redundant text block to improve readability.
DPE is currently looking into what the future of Schematic might look like. This includes the possibility of completely reworking how we handle data models. Currently, Schematic supports data models in CSV or JSON-LD format. Several DCCs are either using or planning on using LinkML to create their data models and then port them to JsonLD for use in schematic. One possibility in Schematic 2.0 (placeholder name) is to make LinkML the format for data models and to use native LinkML functionality where possible to reduce the work that Schematic does. DPE is currently looking into what the future of Schematic might look like. This includes the possibility of completely reworking how we handle data models. Currently, Schematic supports data models in CSV or JSON-LD format. Several DCCs are either using or planning on using LinkML to create their data models and then port them to JsonLD for use in schematic. One possibility in Schematic 2.0 (placeholder name) is to make LinkML the format for data models and to use native LinkML functionality where possible to reduce the work that Schematic does.

docs/source/manifest_validation.rst:44

  • You’ve added '*' adornments above and below 'Requirements' but left the old hyphen underline. Remove this redundant hyphen line to keep a single, consistent heading style.
************

docs/source/manifest_validation.rst:13

  • The ref target 'installation:6. Set up configuration files' doesn’t match the defined anchor. Update it to the actual label (e.g., installation:Set up configuration files) or adjust the anchor to match.
Ensure you have a Synapse account and set up Synapse configuration file correctly. See the :ref:`setting up configuration files <installation:6. Set up configuration files>` section for more details.

docs/source/manifest_submission.rst:11

  • The ref target 'installation:6. Set up configuration files' is likely incorrect; align it with the actual anchor name, such as installation:Set up configuration files.
Ensure you have a Synapse account and set up Synapse configuration file correctly. See the :ref:`setting up configuration files <installation:6. Set up configuration files>` section for more details.

Copy link
Member

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave these changes a read and tabbed around the readthedocs pages. Didn't find anything broken!

@thomasyu888 thomasyu888 requested a review from andrewelamb July 2, 2025 20:37
@SageGJ
Copy link
Collaborator Author

SageGJ commented Jul 2, 2025

For those reviewing here is a link to the rendered doc pages:
https://schematicpy--1624.org.readthedocs.build/en/1624/

@BryanFauble thanks for sharing that! That link is also included in the PR description under the Reviewing Instructions section

Also thanks for taking a look through!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2025

@thomasyu888 thomasyu888 changed the title fix errors in index.rst [schematic-320] fix errors in index.rst Jul 3, 2025
@andrewelamb
Copy link
Contributor

@SageGJ Every link I tried worked!

@SageGJ
Copy link
Collaborator Author

SageGJ commented Jul 3, 2025

@andrewelamb thanks for reviewing!

@SageGJ SageGJ changed the title [schematic-320] fix errors in index.rst [schematic-320] Standardize and Update Documentation Pages Jul 3, 2025
@SageGJ SageGJ changed the title [schematic-320] Standardize and Update Documentation Pages [SCHEMATIC-320] Standardize and Update Documentation Pages Jul 3, 2025
@SageGJ SageGJ merged commit e8b3b61 into develop Jul 3, 2025
9 checks passed
@SageGJ SageGJ deleted the schematic-320 branch July 3, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants