[SCHEMATIC-308] Add ability for JSON Schema type to be set by columnType attribute #1625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SageGJ
approved these changes
Jul 8, 2025
Collaborator
SageGJ
left a comment
SageGJ
left a comment
There was a problem hiding this comment.
LGTM
new code logic looks sound and the tests cover the variety of cases appropriately.
andrewelamb
changed the title
andrewelamb
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCHEMATIC-308
Problem:
When creating a JSON Schema, the type is inferred from existing validation rules if they exist. It would be better if the type were set explicitly in the data model.
Solution:
The JSON Schema creation function will look for the columnType attribute in the data model graph and use it to set the JSON Schema type if it exists. Otherwise, it will continue to infer the type from the validation rules. Infering from validaiton rules has been deprecated and will be sunsetted in the future.
Testing:
Unit tests for both when the node has the columType attribute and when it doesn't.