fix bug where there no validation rules set #1628
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewelamb
commented
Jul 9, 2025
andrewelamb
commented
Jul 9, 2025
Contributor
Author
|
@SageGJ I added the updates to the invalid columnType data models here since the other PR was merged. |
SageGJ
approved these changes
Jul 10, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
During validation of the
columnTypePR, I discovered a bug where if there is an explicit type, but no validation rules, the type is not added.Solution:
The default is now to set the type as the explicit type.
Testing:
A case for when there is an explicit type set but no validation rules.