Skip to content

Conversation

@SageGJ
Copy link
Collaborator

@SageGJ SageGJ commented Jul 10, 2025

Problem:

A our version of flask was incompatible with the latest werkzeug version

Solution:

The version of werkzeug was pinned

Testing:

pre-release API tests pass after update

@SageGJ SageGJ requested a review from a team as a code owner July 10, 2025 19:07
@SageGJ SageGJ changed the base branch from develop to v25.7.1-rc-dev July 10, 2025 19:07
Copy link
Member

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting a max version looks fine to me, however, some of the checks are failing and need to be resolved before merge.

@andrewelamb
Copy link
Contributor

@SageGJ It looks like a lot of packages were updated. Did they all need to be?

@SageGJ
Copy link
Collaborator Author

SageGJ commented Jul 10, 2025

@andrewelamb if you're referring to the poetry.lock then yes. That file is generated automatically by poetry based on the pyproject.toml so if changes were made there then they're necessary

@SageGJ
Copy link
Collaborator Author

SageGJ commented Jul 10, 2025

@BryanFauble yeah, it looks like they're mypy errors about packages not being installed. Separately, have you seen the trivy results?

@andrewelamb
Copy link
Contributor

andrewelamb commented Jul 10, 2025

@SageGJ I was able to add the werkzeug version restriction here
via poetry without having to update all the other packages.

@SageGJ
Copy link
Collaborator Author

SageGJ commented Jul 10, 2025

@andrewelamb okay cool that works

@SageGJ SageGJ closed this Jul 10, 2025
@SageGJ SageGJ deleted the dependency-update branch July 10, 2025 20:08
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants