[SCHEMATIC-360] Add script to write jsonschemas to a synapse table #1642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanFauble
reviewed
Sep 8, 2025
| # exclude HTAN1, HTAN2, and NF schemas as they have their own JSONschema organizations | ||
| df = df[~df["dcc"].isin(["htan", "htan2", "nf"])] | ||
| table = Table(id="syn69735275").get(include_columns=True) | ||
| table.upsert_rows(values=df, primary_keys=["uri"]) |
Member
There was a problem hiding this comment.
Great to see this upsert functionality getting some use!
Member
Author
|
This could probably be added to the extensions package instead of this repo |
andrewelamb
reviewed
Oct 15, 2025
| """ | ||
| syn = synapseclient.login() | ||
| # json_schema_organizations = ["sage.schemas.v2571", "sage.schemas.v2581"] | ||
| json_schema_organizations = ["sage.schemas.v2571", "sage.schemas.v2581"] |
Contributor
There was a problem hiding this comment.
Would it make sense to have the orgs as a parameter to the main function so that if/when we add new orgs we wouldn't have to update this?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently, we maintain a Confluence page manually with the JSON schemas we generate that can be used for Curator MVP. This won't scale as we create more JSON schemas.
Solution:
Add ad-hoc script to write jsonschemas that DPE generates to a synapse table for Curator MVP. This is partially doing some of schematic-360 work and adds a 'script' directory
Testing:
View Synapse table here: https://www.synapse.org/Synapse:syn69735275/tables/