Fix some invalid HTML issues #2038
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
commented
Jul 15, 2025
| > | ||
| <Typography | ||
| variant="sectionTitle" | ||
| component={'div'} |
There was a problem hiding this comment.
This component contains divs, so it cannot be a p.
nickgros
commented
Jul 15, 2025
| vi.mock('./widget/MarkdownSynapsePlot', () => ({ | ||
| default: vi | ||
| .fn() | ||
| .mockReturnValue(<figure data-testid={'MarkdownSynapsePlot'}></figure>), |
There was a problem hiding this comment.
figure cannot be in a p, so fix this invalid mock.
nickgros
commented
Jul 15, 2025
Comment on lines
-229
to
-232
| const Tag: keyof JSX.IntrinsicElements | typeof Fragment = | ||
| element.tagName.toLowerCase() === 'body' | ||
| ? Fragment // The component ultimately wraps this content, so if the tag is 'body', we use Fragment to avoid an extra nested element | ||
| : (element.tagName.toLowerCase() as keyof JSX.IntrinsicElements) |
There was a problem hiding this comment.
I previously changed the body element to map to a fragment, but this causes us to add props to the Fragment, which is invalid. Instead, map the body tag directly to the wrapper element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix invalid HTML issues in