-
Couldn't load subscription status.
- Fork 30
SWC-6173 #2103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SWC-6173 #2103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR transitions from automated npm publishing based on version changes in the main branch to a manual workflow dispatch system. The change allows for more controlled releases by requiring explicit inputs for package name, version, and git reference.
- Replaces automatic version-based publishing with manual workflow triggers
- Resets all package versions to 0.0.0 as a baseline for the new release process
- Updates documentation to reflect the new manual release workflow
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/*/package.json | Reset package versions to 0.0.0 for new manual release process |
| .github/workflows/npmpublish.yml | Removed old automated workflow that triggered on version changes |
| .github/workflows/npm-publish.yml | Added new manual workflow with dispatch inputs for controlled releases |
| README.md | Updated documentation to describe new manual release process |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
| { | ||
| "name": "@sage-bionetworks/markdown-it-container", | ||
| "version": "4.0.1", | ||
| "version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set all packages to v0.0.0 since the version is set in the workflow. The engineer releasing the new version should reference NPM or the repository tags to identify the previous release version.
|
Is there a relatively easy way to automatically generate the SRC release notes and set as the latest release? |
|
@jay-hodgson Not sure if we want to automate that, the generated release notes are not scoped to each package (includes all changes in the repo) so that should probably remain a manual process (e.g. if release a new version of markdown-it-synapse, we don't want the release to include all repo changes since the previous release) |
|
Actually, I am not sure how this will work with the |
Update npm publish workflow to manually trigger releases.
This would no longer require code changes to publish new versions of packages, and would also simplify releasing 'patch' versions of packages that do not include all the latest changes.