Skip to content

Conversation

@nickgros
Copy link
Collaborator

@nickgros nickgros commented Aug 15, 2025

Update npm publish workflow to manually trigger releases.

This would no longer require code changes to publish new versions of packages, and would also simplify releasing 'patch' versions of packages that do not include all the latest changes.

image

This comment was marked as outdated.

Update npm publish workflow to manually trigger releases
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR transitions from automated npm publishing based on version changes in the main branch to a manual workflow dispatch system. The change allows for more controlled releases by requiring explicit inputs for package name, version, and git reference.

  • Replaces automatic version-based publishing with manual workflow triggers
  • Resets all package versions to 0.0.0 as a baseline for the new release process
  • Updates documentation to reflect the new manual release workflow

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

File Description
packages/*/package.json Reset package versions to 0.0.0 for new manual release process
.github/workflows/npmpublish.yml Removed old automated workflow that triggered on version changes
.github/workflows/npm-publish.yml Added new manual workflow with dispatch inputs for controlled releases
README.md Updated documentation to describe new manual release process

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

{
"name": "@sage-bionetworks/markdown-it-container",
"version": "4.0.1",
"version": "0.0.0",
Copy link
Collaborator Author

@nickgros nickgros Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set all packages to v0.0.0 since the version is set in the workflow. The engineer releasing the new version should reference NPM or the repository tags to identify the previous release version.

@jay-hodgson
Copy link
Member

Is there a relatively easy way to automatically generate the SRC release notes and set as the latest release?

@nickgros
Copy link
Collaborator Author

@jay-hodgson Not sure if we want to automate that, the generated release notes are not scoped to each package (includes all changes in the repo) so that should probably remain a manual process (e.g. if release a new version of markdown-it-synapse, we don't want the release to include all repo changes since the previous release)

@nickgros nickgros marked this pull request as draft August 20, 2025 19:04
@nickgros
Copy link
Collaborator Author

Actually, I am not sure how this will work with the workspace:* identifiers in our package.json. This could break internal transitive dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants