Skip to content

Conversation

@BryanFauble
Copy link
Member

Problem:

  1. Within schematic there is a need to know the ID of the user that is logged in as it is passed to the Synapse servers to lookup data the user has access to. What needed to be done was another HTTP call to get the user profile and then extract the ownerId from that call.

Solution:

  1. When logging into Synapse and getting the user profile stash the ownerId onto the credentials object so that schematic can use this and skip an HTTP call.

Testing:

  1. Unit test
  2. I have been using this code locally within schematic.

@BryanFauble BryanFauble requested a review from a team as a code owner September 17, 2024 18:09
@pep8speaks
Copy link

pep8speaks commented Sep 17, 2024

Hello @BryanFauble! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 180:89: E501 line too long (94 > 88 characters)

Comment last updated at 2024-09-17 18:37:37 UTC

@jaymedina
Copy link
Contributor

Nice work! 🚀

@BryanFauble BryanFauble merged commit 70c8aac into develop Sep 17, 2024
22 checks passed
@BryanFauble BryanFauble deleted the fds-2386-store-owner-id-on-credentials branch September 17, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants