Skip to content

[SYNPY-1589] Implement documentation of Evaluation OOP model #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: [SYNPY-1589] Implement "Evaluation" OOP model
merged 13 commits into from
Oct 22, 2025
Merged

[SYNPY-1589] Implement documentation of Evaluation OOP model #1247

merged 13 commits into from
Oct 22, 2025
+309 −35

Conversation

@jaymedina
Copy link
Contributor

See #1244

BryanFauble
BryanFauble reviewed Sep 30, 2025
View reviewed changes
BryanFauble
BryanFauble reviewed Sep 30, 2025
View reviewed changes
BryanFauble
BryanFauble reviewed Sep 30, 2025
View reviewed changes
BryanFauble
BryanFauble reviewed Sep 30, 2025
View reviewed changes
BryanFauble
BryanFauble reviewed Sep 30, 2025
View reviewed changes
BryanFauble
BryanFauble reviewed Sep 30, 2025
View reviewed changes
linglp
linglp reviewed Oct 1, 2025
View reviewed changes
linglp
linglp reviewed Oct 1, 2025
View reviewed changes
linglp
linglp reviewed Oct 1, 2025
View reviewed changes
jaymedina
jaymedina commented Oct 1, 2025
View reviewed changes
@jaymedina jaymedina mentioned this pull request Oct 9, 2025
Merged
thomasyu888
thomasyu888 approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@thomasyu888 thomasyu888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 LGTM!

@jaymedina jaymedina force-pushed the synpy-1589-evaluation-model-docs branch from 7bd39dd to cedc4e1 Compare October 17, 2025 22:55
@jaymedina jaymedina force-pushed the synpy-1589-evaluation-model-docs branch from cedc4e1 to cc0a1e1 Compare October 17, 2025 22:56
@jaymedina jaymedina changed the base branch from develop to synpy-1589-evaluation-model-main October 17, 2025 22:57
@jaymedina jaymedina marked this pull request as ready for review October 22, 2025 17:28
@jaymedina jaymedina requested a review from a team as a code owner October 22, 2025 17:28
BryanFauble
BryanFauble reviewed Oct 22, 2025
View reviewed changes
BryanFauble
BryanFauble reviewed Oct 22, 2025
View reviewed changes
BryanFauble
BryanFauble reviewed Oct 22, 2025
View reviewed changes
BryanFauble
BryanFauble approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@BryanFauble BryanFauble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I left a few comments/suggestions on areas to double check and improve.

@jaymedina jaymedina merged commit 69a713e into synpy-1589-evaluation-model-main Oct 22, 2025
18 of 19 checks passed
@jaymedina jaymedina deleted the synpy-1589-evaluation-model-docs branch October 22, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linglp linglp linglp left review comments

@thomasyu888 thomasyu888 thomasyu888 approved these changes

@BryanFauble BryanFauble BryanFauble approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaymedina @thomasyu888 @BryanFauble @linglp