-
Couldn't load subscription status.
- Fork 72
[SYNPY-1667]Update Error Messaging when Attempting to Delete Rows that do not exist from Tables #1257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥 LGTM! I'll defer to the team for final review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for this patch
|
LGTM, thanks for working on this. |
8cc052e to
172071d
Compare
|
The last failure was a single test that had permission issues: I'm going to go ahead and merge this pr given that this was a known issue. |
The other versions passed so I dont have an issue merging just because of this failure. Either way - I did go ahead and reran the failed test in github action. |
Problem:
The error messages displayed when a user tried to delete rows from a table and the rows did not exist were unclear and confusing.
Solution:
The way discrepant rows were identified and formatted for display were changed. A new test was added to ensure that the error message accurately conveys what the error was and where the problem lies.
Testing:
Unit tests were updated, new integration tests were added, and the validation script was used afterwards.
Continuation of #1254