[SYNPY-1674] Update to Form services #1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryanFauble
approved these changes
Dec 19, 2025
Member
BryanFauble
left a comment
BryanFauble
left a comment
There was a problem hiding this comment.
Nothing stood out to me on the review, thanks for the changes! LGTM!
thomasyu888
reviewed
Dec 19, 2025
thomasyu888
reviewed
Dec 19, 2025
15 tasks
thomasyu888
approved these changes
Dec 26, 2025
Member
thomasyu888
left a comment
thomasyu888
left a comment
There was a problem hiding this comment.
🔥 LGTM! Thanks for the work and reviews here!
|
The changes look good. Thanks for your work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
create_or_getinstead ofcreatefilter_by_stateis an optional parameter. If this parameter is not provided, it should give users all the possible filterslistis under form group instead of form