Skip to content

[SYNPY-1824] fix syn.sendMessage in async context #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
linglp merged 4 commits into from
Apr 29, 2026
+28 −16
Merged

[SYNPY-1824] fix syn.sendMessage in async context #1370

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8482054
try fixing the syn.sendMessage
Apr 24, 2026
56fcb30
comment out test_boto_upload_acl and test_sts_external_storage_location
Apr 27, 2026
3a37730
uncomment but test but added
Apr 29, 2026
9b3805f
[SYNPY-1826] fix integration test: test_download_list_manifest_with_c…
linglp Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions synapseutils/monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ async def with_retry_and_messaging(*args, **kwargs):
while attempt <= retries:
try:
output = await func(*args, **kwargs)
syn.sendMessage(
await syn.sendMessage_async(
[destination],
messageSubject,
messageBody="Call to %s completed successfully!"
Expand All @@ -146,7 +146,7 @@ async def with_retry_and_messaging(*args, **kwargs):
syn.logger.exception(
f"Encountered a temporary Failure during execution. Will retry {retries - attempt} more times."
)
syn.sendMessage(
await syn.sendMessage_async(
[destination],
messageSubject,
messageBody=(
Expand Down
Loading