[SYNPY-1826] fix integration test: test_download_list_manifest_with_custom_csv_descriptor#1372
Draft
linglp wants to merge 3 commits intoSYNPY-1824from
Draft
[SYNPY-1826] fix integration test: test_download_list_manifest_with_custom_csv_descriptor#1372linglp wants to merge 3 commits intoSYNPY-1824from
linglp wants to merge 3 commits intoSYNPY-1824from
Conversation
added 3 commits
April 27, 2026 17:07
linglp
commented
Apr 27, 2026
| assert "\t" in content, "Expected tab separators in manifest" | ||
|
|
||
| # AND the escape character was used for the embedded quote in the file name | ||
| assert "/'" in content, ( |
Contributor
Author
There was a problem hiding this comment.
After thinking about this more, this maybe a server side error. If Per the Synapse docs, escapeCharacter is "for escaping a separator or quote". So the spec says it should produce:'it/'s_test.csv' when the file name is: 'it's_test.csv'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Integration test failure
Solution: