Skip to content

Conversation

@Parsium
Copy link
Contributor

@Parsium Parsium commented Nov 24, 2025

closes #7638

Proposed behaviour

If Loader is rendered within a Button, use its text colour to style the label and inner ring arc. This ensures sufficient colour contrast between the label text and Button background, even when hovered:

Screen.Recording.2025-11-24.at.12.09.04.mov

Current behaviour

When Loader is rendered within a secondary or tertiary Button, there is insufficient colour contrast between the label text and button background:

Screen.Recording.2025-11-24.at.12.08.07.mov

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

This is a temporary fix while #7624 is under development. The designs of the updated Button include new hover colours for secondary and tertiary buttons, which shouldn't have this contrast issue.

Testing instructions

edleeks87
edleeks87 previously approved these changes Nov 24, 2025
@DipperTheDan DipperTheDan self-requested a review November 25, 2025 10:00
DipperTheDan
DipperTheDan previously approved these changes Nov 25, 2025
@Parsium Parsium marked this pull request as ready for review November 25, 2025 13:15
@Parsium Parsium requested review from a team as code owners November 25, 2025 13:15
@Parsium Parsium dismissed stale reviews from DipperTheDan and edleeks87 via ea65dbe November 27, 2025 15:52
@Parsium Parsium marked this pull request as draft November 27, 2025 15:52
@Parsium Parsium force-pushed the loader-button-contrast-fix branch 4 times, most recently from d8314fe to 420439f Compare November 28, 2025 09:59
@divyajindel divyajindel marked this pull request as ready for review November 28, 2025 11:11
@Parsium Parsium marked this pull request as draft December 1, 2025 17:04
@Parsium Parsium force-pushed the loader-button-contrast-fix branch from 94dc745 to 9b75709 Compare December 1, 2025 17:09
@Parsium Parsium marked this pull request as ready for review December 1, 2025 17:11
@Parsium Parsium merged commit 98893b1 into master Dec 1, 2025
29 checks passed
@Parsium Parsium deleted the loader-button-contrast-fix branch December 1, 2025 17:27
@carbonci
Copy link
Collaborator

carbonci commented Dec 1, 2025

🎉 This PR is included in version 158.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Loader inside button - contrast issue

6 participants