fix(loader): inherit text colour from parent Button, if it exists #7639
+70
−342
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7638
Proposed behaviour
If
Loaderis rendered within aButton, use its text colour to style the label and inner ring arc. This ensures sufficient colour contrast between the label text andButtonbackground, even when hovered:Screen.Recording.2025-11-24.at.12.09.04.mov
Current behaviour
When
Loaderis rendered within a secondary or tertiaryButton, there is insufficient colour contrast between the label text and button background:Screen.Recording.2025-11-24.at.12.08.07.mov
Checklist
d.tsfile added or updated if requiredQA
Additional context
This is a temporary fix while #7624 is under development. The designs of the updated
Buttoninclude new hover colours for secondary and tertiary buttons, which shouldn't have this contrast issue.Testing instructions