-
Notifications
You must be signed in to change notification settings - Fork 85
fix(dialog): long titles now wrap #7679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
405217c to
9a87131
Compare
6d6c775
c295312
c295312 to
15ea485
Compare
ensures titles which would typically exceed the length of the component and overflow, now wrap instead fix #7653
edleeks87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tomdavies73 I'm happy to move this into QA as the comment I've left won't affect the outcome of that, you can just amend when you get back if you want etc
| )} | ||
| {subtitle && ( | ||
| <div | ||
| style={{ marginTop: "5px", width: "100%", flexBasis: "100%" }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment (non-blocking): for consistency/maintenance sake we should avoid inlining the styles.
fix #7653
Proposed behaviour
Now ensures titles which would typically exceed the length of the component and overflow, now wrap instead
Current behaviour
Titles whic exceed the length of the component overflow
Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions