Skip to content

Conversation

@tomdavies73
Copy link
Contributor

@tomdavies73 tomdavies73 commented Dec 16, 2025

fix #7653

Proposed behaviour

Now ensures titles which would typically exceed the length of the component and overflow, now wrap instead

Current behaviour

Titles whic exceed the length of the component overflow

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

DipperTheDan
DipperTheDan previously approved these changes Dec 18, 2025
Parsium
Parsium previously approved these changes Dec 18, 2025
DipperTheDan
DipperTheDan previously approved these changes Dec 18, 2025
Parsium
Parsium previously approved these changes Dec 18, 2025
@Parsium Parsium marked this pull request as ready for review December 18, 2025 14:23
@Parsium Parsium requested review from a team as code owners December 18, 2025 14:23
@tomdavies73 tomdavies73 dismissed stale reviews from Parsium and DipperTheDan via c295312 December 18, 2025 14:55
@tomdavies73 tomdavies73 force-pushed the FE-7542 branch 2 times, most recently from c295312 to 15ea485 Compare December 19, 2025 15:11
ensures titles which would typically exceed the length of the component and overflow, now wrap
instead

fix #7653
@tomdavies73 tomdavies73 requested a review from a team as a code owner December 19, 2025 16:45
@tomdavies73 tomdavies73 marked this pull request as draft December 19, 2025 16:52
Copy link
Contributor

@edleeks87 edleeks87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomdavies73 I'm happy to move this into QA as the comment I've left won't affect the outcome of that, you can just amend when you get back if you want etc

)}
{subtitle && (
<div
style={{ marginTop: "5px", width: "100%", flexBasis: "100%" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment (non-blocking): for consistency/maintenance sake we should avoid inlining the styles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Dialog - word break in title

4 participants