Skip to content

feat(note): align Note component with Fusion DS - #8125

Open
ibutakova wants to merge 2 commits into
masterfrom
FE-7187-align-note-with-fusion-ds
Open

feat(note): align Note component with Fusion DS#8125
ibutakova wants to merge 2 commits into
masterfrom
FE-7187-align-note-with-fusion-ds

Conversation

@ibutakova

Copy link
Copy Markdown
Contributor

Proposed behaviour

Align Note component with Fusion DS:

  • Replace token-based colours and spacing with Fusion DS global tokens
  • Render title as a semantic

    instead of Typography CSS-only variant

  • Move inline ActionPopover into the body layout; provide default ellipsis icon button
  • Replace status tooltip with inline elements; add locale.note.created() i18n key for "Created" label
  • Add isValidISOString util to set machine-readable datetime attributes on elements
  • Render @mention nodes as read-only pills
  • Add spellCheck={false} to ReadOnlyEditor
  • Conditionally render previews section to avoid empty DOM nodes
  • Remove dead StatusIcon internal component
  • Add WithInlineControlsWithoutTitle and WithMention stories

Current behaviour

Note component is not aligned with Fusion DS

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in provided StackBlitz sandbox/Storybook
  • Add new Playwright test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Screenshot 2026-08-11 at 12 49 38 Screenshot 2026-08-11 at 12 53 27 Screenshot 2026-08-11 at 12 53 56 Screenshot 2026-08-11 at 12 54 48 Screenshot 2026-08-11 at 12 55 13

Comment thread src/components/note/note.style.ts Outdated
Comment on lines +184 to +190
margin: 0;
min-width: 0;
overflow: hidden;

${StyledPreviewWrapper} {
min-width: 0;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: You can use the ...none token values here instead. I can find the actual token names if you need them 👍🏻

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that thing one more time. Thanks)

@ibutakova
ibutakova force-pushed the FE-7187-align-note-with-fusion-ds branch from 4ae1ce1 to 456abcf Compare August 12, 2026 07:34
DipperTheDan
DipperTheDan previously approved these changes Aug 12, 2026
@ibutakova
ibutakova marked this pull request as ready for review August 14, 2026 10:44
@ibutakova
ibutakova requested review from a team as code owners August 14, 2026 10:44
@designerlisa

designerlisa commented Aug 19, 2026

Copy link
Copy Markdown

@ibutakova Thanks for the great work!
Luke has confirmed that 4px is deliberate update as the footer looked too large. All looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants