feat(action-popover): use subtle Action trigger and deprecate positio… - #8137
Draft
tamas-sage wants to merge 4 commits into
Draft
feat(action-popover): use subtle Action trigger and deprecate positio…#8137tamas-sage wants to merge 4 commits into
tamas-sage wants to merge 4 commits into
Conversation
Contributor
|
We should be using the PopoverMenu to replace the existing menu, you may need to do some mapping/aliasing to get it to work, happy to chat about it on slack if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Use a subtle Action button with a three-dots icon, keep it outlined while open, deprecate manual positioning props, and rely on automatic flipping with docs/stories showing text and textless render-prop examples.
Current behaviour
Most of this is implemented (subtle Action button, open-state outline, deprecations, and examples), but the trigger icon is still dropdown in the component/stories instead of three dots.

Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions