feat(batch-selection): align with Fusion DS - #8152
Draft
nuria1110 wants to merge 1 commit into
Draft
Conversation
Aligns BatchSelection component to Bulk Actions pattern in Fusion DS. Deprecates `disabled` and `colorTheme` props.
nuria1110
force-pushed
the
batch-selection-audit
branch
from
August 26, 2026 12:53
b83be4c to
718407c
Compare
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview
Aligns BatchSelection with the Fusion DS “Bulk Actions” pattern by updating its layout, behavior, and supporting i18n/docs/tests. This refactor removes the previous “disabled children via context” behavior and introduces a dismiss/close affordance and a “selected out of total” message.
Changes:
- Updates
BatchSelectionUI structure to a tile-based layout, addsonDismiss,smallScreen, andtotalItemssupport, and removes the internal “disable children” context. - Updates i18n locale shape (
batchSelection.ariaLabels.close, updatedselectedsignature) and refreshes component docs/stories/tests accordingly. - Removes BatchSelection-context-based disabling logic from
Button,ButtonMinor,IconButton, andLink.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/batch-selection/batch-selection.component.tsx | Refactors component to Fusion DS layout; adds dismiss button + total-items messaging. |
| src/components/batch-selection/batch-selection.style.ts | Replaces legacy styling with new wrapper/content layout styles. |
| src/components/batch-selection/batch-selection.stories.tsx | Updates Storybook stories to new pattern and adds example implementation. |
| src/components/batch-selection/batch-selection.mdx | Updates documentation copy, examples, and translation keys table. |
| src/components/batch-selection/batch-selection.test.tsx | Updates RTL unit tests to new rendering and dismiss behavior. |
| src/components/batch-selection/components.test-pw.tsx | Updates Playwright mount component to use new Button-based actions. |
| src/components/batch-selection/batch-selection.pw.tsx | Simplifies a11y coverage to new supported variants (default/hidden). |
| src/components/batch-selection/batch-selection-test.stories.tsx | Updates chromatic snapshot coverage to new layout + small-screen variant. |
| src/components/batch-selection/batch-selection-interaction.stories.tsx | Removes legacy interaction stories tied to old UI structure. |
| src/components/batch-selection/internal/batch-selection.context.ts | Removes now-unused context used for disabling child actions. |
| src/components/button/button.component.tsx | Removes BatchSelectionContext-based disabling logic from legacy Button. |
| src/components/button-minor/button-minor.component.tsx | Removes BatchSelectionContext-based disabling logic from ButtonMinor. |
| src/components/icon-button/icon-button.component.tsx | Removes BatchSelectionContext-based disabling logic from IconButton. |
| src/components/link/link.component.tsx | Removes BatchSelectionContext-based disabling logic from Link. |
| src/locales/locale.ts | Extends locale contract for BatchSelection aria label + total-aware selected message. |
| src/locales/en-gb.ts | Adds BatchSelection close aria label and updates selected text format. |
| src/locales/de-de.ts | Adds BatchSelection close aria label. |
| src/locales/es-es.ts | Adds BatchSelection close aria label. |
| src/locales/fr-fr.ts | Adds BatchSelection close aria label. |
| src/locales/fr-ca.ts | Adds BatchSelection close aria label. |
| src/locales/pt-pt.ts | Adds BatchSelection close aria label. |
| skills/carbon-react/components/batch-selection.md | Updated (content excluded by policy; not reviewed). |
Files excluded by content exclusion policy (1)
- skills/carbon-react/components/batch-selection.md
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
40
to
44
| export const BatchSelection = ({ | ||
| disabled = false, | ||
| disabled, | ||
| children, | ||
| colorTheme = "transparent", | ||
| colorTheme, | ||
| selectedCount, |
Contributor
Author
There was a problem hiding this comment.
May have to have to maintain the previous translation key to prevent this and only render the new one when totalItems is provided.
edleeks87
reviewed
Aug 27, 2026
| disabled?: boolean; | ||
| /** Hidden if true */ | ||
| /** If true, the component is hidden. */ | ||
| hidden?: boolean; |
Contributor
There was a problem hiding this comment.
suggestion (non-blocking): I think we could deprecate the hidden prop and just encourage conditional rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed behaviour
Aligns
BatchSelectioncomponent to Bulk Actions pattern in Fusion DS.Deprecates
disabledandcolorThemeprops.Current behaviour
BatchSelectionis not aligned with Fusion DS.Checklist
d.tsfile added or updated if requiredQA
Additional context
Testing instructions