Fix routing rules referencing endpoints being filtered out #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two related issues were fixed: 1. The filter_null_references filter only checked if routing rules referenced valid outbounds, causing rules that reference endpoints to be incorrectly removed 2. Endpoints were assigned to options after template rendering and filtering, so the filter couldn't access them Changes: - Modified filter to allow routing rules to reference both outbounds and endpoints as valid targets - Moved endpoint assignment to before filtering by passing endpoints to template.Render() and setting them early in the render process - This allows custom_rules in extended templates to route traffic to endpoints (e.g., Tailscale) without being filtered out 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two related issues were fixed:
Changes:
🤖 Generated with Claude Code