Fix panic message for removed features #3642
Open
+25,187
−4,802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We mistakenly believed that `libresolv`'s `search` function worked correctly in NetworkExtension, but it seems only `getaddrinfo` does. This commit changes the behavior of the `local` DNS server in NetworkExtension to prefer DHCP, falling back to `getaddrinfo` if DHCP servers are unavailable. It's worth noting that `prefer_go` does not disable DHCP since it respects Dial Fields, but `getaddrinfo` does the opposite. The new behavior only applies to NetworkExtension, not to all scenarios (primarily command-line binaries) as it did previously. In addition, this commit also improves the DHCP DNS server to use the same robust query logic as `local`.
We do not have the `com.apple.developer.networking.multicast` entitlement and are unable to obtain it for non-technical reasons.
Log start/close operations with timing information for debugging.
Adds `chrome` as a new certificate store option alongside `mozilla`. Both stores filter out China-based CA certificates.
Signed-off-by: CatMe0w <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR improves the panic message shown when a deprecated feature is used after its scheduled removal date. Instead of displaying an internal identifier like "invalid deprecated note: bad-match-source", the code now shows a user-friendly message that includes the feature description, deprecation timeline, and migration link.
Key change:
- Modified the panic message in
Impending()to useMessageWithLink()for better user experience
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nekohasekai
force-pushed
the
dev-next
branch
8 times, most recently
from
b58d0a0 to
4e73574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a deprecated feature is used after its scheduled removal, sing-box used to panic with an internal name (e.g.
invalid deprecated note: bad-match-source), which confused end users.This change makes the panic message match the deprecation notice style, so users immediately know what to change.
Full log, using sing-box version 1.12.13: