Expose GSO capability through LinkEndpointFilter - #90
Open
kevmo314 wants to merge 1 commit into
Open
Conversation
LinkEndpointFilter embeds the stack.LinkEndpoint interface, which promotes only that interface's methods. The fdbased endpoint underneath also implements stack.GSOEndpoint, but the filter did not, so gVisor's Route.HasHostGSOCapability type assertion on the NIC's endpoint failed and every TCP endpoint sent MSS-sized segments even with vnet_hdr offload on. Passing the two methods through lets the sender build 64 KiB segments for the kernel to split. On an MT7986 router a single-stream download through the gvisor stack went from 192 to 513 Mbit/s and upload from 828 to 907.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose the wrapped endpoint’s GSO capabilities through LinkEndpointFilter so gVisor can send larger TCP segments for the kernel to split. Without this, the filter hides offload support and forces gVisor to send MSS-sized segments, limiting throughput.
gVisor already checks whether its link endpoint implements stack.GSOEndpoint so this allows gVisor to pick up on the otherwise hidden interface and increase throughput.