Fix: Deep Research Functionality - Parameter Fixes, Rate Limiting & Timeout Handling #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix parameter name mismatch in run_deep_search function - Add missing await keyword when calling async run_deep_search function - Resolves three errors: parameter name mismatch, undefined variable, and "Cannot unpack non-iterable coroutine object"
- Implement 4-minute default timeout (configurable via MCP_MAX_DURATION_SECONDS) - Add timeout checks before/after each search iteration - Gracefully terminate with partial results when approaching timeout - Properly integrate with existing rate limiter (REQUESTS_PER_MINUTE) - Document environment variables in server.py - Ensure browser resources are properly closed on early termination
deciduus
changed the title
kazekulin
approved these changes
Apr 26, 2025
kazekulin
approved these changes
Apr 26, 2025
kazekulin
approved these changes
Apr 26, 2025
|
Sorry for my late reply, and thank you for this contribution. I have updated some code, and deep research is working now, though I haven't tested the MCP timeouts yet. Given that this is such a lengthy process, I think it would be nice to implement state restoration to allow users to resume interrupted research sessions. Could you update the PR to reflect the latest changes? |
|
Yes I'll give this a look shortly. Thanks!
…On Fri, May 9, 2025, 8:14 PM Igor Tarasenko ***@***.***> wrote:
*Saik0s* left a comment (Saik0s/mcp-browser-use#16)
<#16 (comment)>
Sorry for my late reply, and thank you for this contribution. I have
updated some code, and deep research is working now, though I haven't
tested the MCP timeouts yet. Given that this is such a lengthy process, I
think it would be nice to implement state restoration to allow users to
resume interrupted research sessions. Could you update the PR to reflect
the latest changes?
—
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BEA7AQ3NE5PTE47PFLZUAAD25VHINAVCNFSM6AAAAAB3EPKVMWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNRYGE3TSNJYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Deep Research Functionality - Parameter Fixes, Rate Limiting & Timeout Handling
Chronological Changes
1. Resolved Parameter and Async Issues (85a51c2)
run_deep_searchfunctionmax_search_iterationstomax_search_iteration_inputmax_query_per_iterationtomax_query_per_iter_inputawaitkeyword when calling asyncrun_deep_searchfunction2. Added Timeout Mechanism and Enhanced Rate Limiting (9db40cf)
RateLimitersingleton class respectingREQUESTS_PER_MINUTEvariableMCP_MAX_DURATION_SECONDSenvironment variable (default: 240)End Result
Deep research now functions correctly with appropriate rate limiting and timeout behavior, preventing MCP timeouts while maximizing research quality within time constraints.