Skip to content

Rename reader argument as path#65

Merged
glopesdev merged 1 commit intomainfrom
io-refactor
Dec 17, 2025
Merged

Rename reader argument as path#65
glopesdev merged 1 commit intomainfrom
io-refactor

Conversation

@glopesdev
Copy link
Contributor

To clarify intent, as file is often reserved for open file handles.

To clarify intent, as file is often reserved for open file handles.
@glopesdev glopesdev requested a review from lochhh December 17, 2025 14:56
@glopesdev glopesdev added the feature New planned feature label Dec 17, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.62%. Comparing base (815c707) to head (3e4444b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #65   +/-   ##
=======================================
  Coverage   71.62%   71.62%           
=======================================
  Files          10       10           
  Lines         652      652           
=======================================
  Hits          467      467           
  Misses        185      185           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lochhh lochhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@glopesdev glopesdev merged commit 3a52039 into main Dec 17, 2025
10 checks passed
@glopesdev glopesdev deleted the io-refactor branch December 17, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New planned feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants