@W-21199544 MCP respect working-directory flag in cartidge and mrt tools#160
Merged
patricksullivansf merged 3 commits intomainfrom Feb 17, 2026
Merged
Conversation
Contributor
Author
|
maybe this needs a changeset too? it's a bit breaking... |
Collaborator
Yuming wrote it as startDir so if this doesn't make sense (it's not a good name to me) we should align the value to workingDirectory and refactor |
2 tasks
854f8df to
3c6d7cc
Compare
Contributor
Author
Aggressively renamed startDir as workingDirectly. LNK if you prefer I scale some renaming back such as the arguments to |
Collaborator
|
As long as tests pass I'm happy. |
clavery
approved these changes
Feb 17, 2026
wei-liu-sf
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This addresses some caveats from #110 and #158
startDirasworkingDirectory; MCP Tools can use the helperservices.getWorkingDirectory()).Testing
In general repro the steps from #110 and #158 and observe the caveats are addressed.
Dependencies
3pl-approvedis set by a maintainerpnpm test)pnpm run format)