Merged
Conversation
github-actions
bot
added
the
needs-3pl-review
allison-grady
requested review from
clavery,
patricksullivansf,
wei-liu-sf and
yhsieh1
as code owners
Contributor
patricksullivansf
left a comment
patricksullivansf
left a comment
There was a problem hiding this comment.
This is cool!
Not sure why this got tagged as needs-3pl-review but no deps have been added.
yhsieh1
added
the
3pl-approved
github-actions
bot
removed
the
needs-3pl-review
yhsieh1
reviewed
Feb 25, 2026
Contributor
yhsieh1
left a comment
yhsieh1
left a comment
There was a problem hiding this comment.
@allison-grady The PR looks good. I updated the label. Please update the branch.
yhsieh1
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the following e2e tests and runs them nightly:
Server starts successfully with default options
Server starts with --toolsets all
Server starts with specific toolsets (--toolsets SCAPI,MRT)
Server starts with specific tools (--tools scapi_discovery)
Server handles --allow-non-ga-tools flag correctly
Server exits cleanly on connection close
Lists tools correctly with --toolsets all --allow-non-ga-tools
Filters tools by toolset correctly
Filters tools by individual tool name
Returns empty list when no tools match
Tool metadata includes correct name, description, inputSchema
Successfully calls placeholder tools and returns expected response
Validates tool input against schema
Returns proper error for unknown tool names
Returns proper error for invalid input
Detects PWA Kit v3 projects from package.json
Detects Storefront Next projects from package.json
Detects cartridge projects from .project files
Falls back to SCAPI toolset when no project detected
Enables combined toolsets for hybrid projects
--config flag is inherited and functional
--log-level flag controls logging output
--debug flag enables debug logging
Instance flags (--server, --client-id, etc.) are accepted
MRT flags (--api-key, --project, etc.) are accepted
Environment variables work as flag alternatives
Invalid JSON-RPC message returns proper error
Unknown method returns proper error
Missing required flags return helpful error message
Testing
To run on CLI:
pnpm -r run buildpnpm --filter @salesforce/b2c-dx-mcp run test:e2eOr visit https://github.com/SalesforceCommerceCloud/b2c-developer-tooling/actions/workflows/e2e-tests.yml, select Run Workflow, select this branch, and run the full nightly test suite.
Example test run
Dependencies
3pl-approvedis set by a maintainerpnpm test)pnpm run format)