Feature w 20796448 figma mcps migration#212
Conversation
Figma MCP Tools Migration - Staged Changes SummaryBranch: OverviewThis document summarizes the staged changes for the Figma MCP tools migration into the Stats: 22 files changed, 4,327 insertions, 18 deletions Modified Filespackages/b2c-dx-mcp/README.md
packages/b2c-dx-mcp/package.json
packages/b2c-dx-mcp/src/tools/storefrontnext/index.ts
pnpm-lock.yaml
New Source Filesfigma-to-component
generate-component
map-tokens
New Test Files
New Test Fixtures
New Documentation
Tool Names (Unchanged from Placeholders)
Quality Gates
|
patricksullivansf
left a comment
There was a problem hiding this comment.
Looks great except for a few lint errors. Please generate new documentation for each tool under docs/mcp/tools and update the docs/mcp/toolsets.md tables with links.
packages/b2c-dx-mcp/src/tools/storefrontnext/figma/figma-to-component/index.ts
Outdated
Show resolved
Hide resolved
| ### AI-Driven Component Discovery (Before calling generate-component) | ||
| Before calling generate-component, you must discover similar components using your tools: | ||
|
|
||
| **Discovery Strategy:** |
There was a problem hiding this comment.
Do we need to provide detailed discovery strategy? Will it better if we only provide the expected result and let Agentic IDE uses its build in approaches to find what we need? It should already indexed files and content and might be faster.
Can we compact and simplify the flow? Too much information might confuse agent and consume more token.
There was a problem hiding this comment.
These tools were demoed by Emmy Zhang under multiple audiences, I will provide some links to the demos. I also think that we can implement improvements in subsequent updates to these tools and just focus on the migration right now as agreed so we can meet the migration timeline of 2/27.
|
@sf-cboscenco It looks great. Some the instruction content seems very long and complex. Is that possible to simplify them? Also it would be great to add jsdoc. |
|
Could you record a demo how these tools are used and the interaction with user? |
|
3pl review: PostCSS is widely used (Tailwind, Vite, VitePress, etc.), actively maintained, and already in your lockfile via VitePress. Version 8.5.6 is pinned, which is good for reproducibility. |
Added jsdoc comments. |
|
One of the demos link, courtesy of Emmy Zhang, thank you! |
|
@sf-cboscenco There are some JSDoc warnings. Could you fix them so that we do not need to come back later? |
Summary
Figma MCP tools migration from Odyssey
Testing
Tests have been included for each MCP tool
test/tools/storefrontnext/figma/README.md| Manual test plan: unit tests, MCP Inspector, CLI testing, E2E workflow, troubleshootingDependencies
3pl-approvedis set by a maintainerNew PostCSS is needed for:
-Parsing @theme at-rules and inline blocks
-Distinguishing light/dark/shared tokens via selectors
-Handling nested rules and var() references
-and that regex-based parsing would be unreliable for real theme files.
pnpm test)pnpm run format)