Skip to content

MCP project folder resolution clean-up#218

Merged
patricksullivansf merged 1 commit intomainfrom
psullivan.mcpProjectFolderResolution
Feb 26, 2026
Merged

MCP project folder resolution clean-up#218
patricksullivansf merged 1 commit intomainfrom
psullivan.mcpProjectFolderResolution

Conversation

@patricksullivansf
Copy link
Contributor

Summary

Replaces confusingly named getWorkingDirectory with more useful resolveWithProjectDirectory.
Fixes spurious references to deprecated --working-directory and SFCC_PROJECT_DIRECTORY.

Testing

Non-user facing change. Regression test only.

Dependencies

  • No net-new third-party dependencies were added
  • If net-new third-party dependencies were added, rationale/discussion is included and 3pl-approved is set by a maintainer

  • Tests pass (pnpm test)
  • Code is formatted (pnpm run format)

Copy link
Contributor

@yhsieh1 yhsieh1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@patricksullivansf patricksullivansf merged commit 8798335 into main Feb 26, 2026
4 checks passed
@patricksullivansf patricksullivansf deleted the psullivan.mcpProjectFolderResolution branch February 26, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants