@W-21435068 Add post action reminder for cartridge deploy mcp tool#233
Merged
@W-21435068 Add post action reminder for cartridge deploy mcp tool#233
Conversation
yhsieh1
requested review from
clavery,
patricksullivansf and
wei-liu-sf
as code owners
wei-liu-sf
reviewed
Mar 4, 2026
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| '@salesforce/b2c-dx-mcp': patch | |||
Collaborator
There was a problem hiding this comment.
what is .changeset used for?
Contributor
Author
wei-liu-sf
reviewed
Mar 4, 2026
| import {getLogger} from '@salesforce/b2c-tooling-sdk/logging'; | ||
|
|
||
| /** Reminder shown after deploy so users add cartridges to the site cartridge path. */ | ||
| const CARTRIDGE_PATH_REMINDER = |
Collaborator
There was a problem hiding this comment.
why not add this to the sdk's post instruction?
Contributor
Author
There was a problem hiding this comment.
This is more specific instruction for the agent. It uses function findAndDeployCartridges which is responsible for the deployment and do not return post action instructions.
Collaborator
There was a problem hiding this comment.
Reminding of setting cartridge path logic is common to both cli and mcp tool. Both can be used by agent, not just mcp tool IMO.
patricksullivansf
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add important reminder in the success Cartridge Deployment response so that the deployed cartridge can be scanned and enabled.
It should remind user to update cartridge path in Business Manager: Sites → Manage Sites → [your site] → Settings tab → Cartridges field.
Testing
Dependencies
3pl-approvedis set by a maintainerpnpm test)pnpm run format)