Fix Annoying things with this Package. #131
Open
bertybot wants to merge 2 commits intoSalesforceCommerceCloud:mainfrom
Open
Fix Annoying things with this Package. #131bertybot wants to merge 2 commits intoSalesforceCommerceCloud:mainfrom
bertybot wants to merge 2 commits intoSalesforceCommerceCloud:mainfrom
Conversation
|
Thanks for the contribution! Before we can merge this, we need @bertybot2 to sign the Salesforce Inc. Contributor License Agreement. |
Contributor
|
Hi @bertybot, thanks for creating this PR! There are a lot of good suggestions in here, and we'd like to include most of them. However, now that node 18 has native fetch support, we will be able to rely on native |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this Change?
This package is currently misconfigured. Running it through publint it has a few errors that need to be addressed.
The main problem being that the ESM configuration is currently misconfigured causing this package to fail to build in ESM centric environments like Vite.
There are also a few other annoying things with this package that should be addressed.
What was done
exportsfieldmodulefieldpackageManagerfield so people can more easily contribute to the projectfetchFunctionproperty to config so that you can supply your own fetch function if you don't like the 2 suppliednode-fetchimportnode-fetchConclusion
These changes most likely constitute a breaking change to users on older versions of Node. However, currently these problems currently make this package completely unusable to people on newer versions or using ESM so I think that the juice is worth the squeeze.