Fix: Revert experimental features (@W-20201209@)#253
Merged
joeluong-sfcc merged 4 commits intomainfrom Nov 17, 2025
Merged
Conversation
* add hot fix * bump size
joeluong-sfcc
changed the title
unandyala
approved these changes
Nov 17, 2025
| throwOnBadResponse?: boolean; | ||
| } | ||
|
|
||
| export type FetchFunction = ( |
Contributor
There was a problem hiding this comment.
why do we need to export the FetchFunction if it is not allowed to pass fetch in the config?
Contributor
Author
There was a problem hiding this comment.
We still use this type in environment.ts
vcua-mobify
approved these changes
Nov 17, 2025
Contributor
vcua-mobify
left a comment
vcua-mobify
left a comment
There was a problem hiding this comment.
Are we going to release a 4.1.1 with this revert?
Contributor
Author
No, we'll be releasing v4.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts features that were released in
v4.1.0that are experimental. These new features caused failing tests in PWA Kit, so we're reverting them temporarily and allowing these features to live in a feature branch until we're ready to merge them back in:#252