Skip to content

Fix CI #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeluong-sfcc merged 10 commits into from
Jul 2, 2025
Merged

Fix CI #422

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0847467
refactor
joeluong-sfcc Jun 24, 2025
00066c7
support x-scapi-internal
joeluong-sfcc Jun 24, 2025
e8740fa
use RAML toolkit
joeluong-sfcc Jun 24, 2025
2089f35
regenerate lockfile
joeluong-sfcc Jun 24, 2025
267bfb0
update config files to ignore node_modules for tsc and eslint
joeluong-sfcc Jun 24, 2025
5b038e0
update depcheck
joeluong-sfcc Jun 24, 2025
9d6148f
Merge branch 'feature/oas' into ju/fix-ci
joeluong-sfcc Jun 26, 2025
e522906
revert some changes
joeluong-sfcc Jun 26, 2025
b32a575
revert tsconfig change
joeluong-sfcc Jul 1, 2025
fd1d57e
update typescript version
joeluong-sfcc Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .depcheckrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,9 @@ ignores:
- retry # Use OperationOptions from retry in templates but not recognized by depcheck
- '@types/retry' # Corresponds to retry
- '@openapitools/openapi-generator-cli' # Used by openapi-generator-cli in `npm run renderTemplates`
- '@types/node-fetch' # Used by multiple files for fetch types
- chai # Used by multiple files for testing
- sinon # Used by multiple files for testing
- nock # Used by multiple files for testing to mock API calls
- handlebars # Used by generation script to generate version.ts and top level index.ts files
- fs-extra # Used by generation script and updateApis script
1 change: 1 addition & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
renderedTemplates
dist/**/*.ts
node_modules
3 changes: 2 additions & 1 deletion base.tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
"noErrorTruncation": true,
"noImplicitReturns": true,
"noImplicitThis": true,
"preserveConstEnums": true
"preserveConstEnums": true,
"skipLibCheck": true
Copy link
Contributor

@vcua-mobify vcua-mobify Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing we're skipping lib check because we removed some types from devDependencies?

Copy link
Collaborator Author

@joeluong-sfcc joeluong-sfcc Jun 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated these files as we didn't need certain changes, but the issue is that we were trying to transpile some typescript in the node_modules that was causing an error when you ran npm run build

> tsc && eslint dist --ext .ts,.js --quiet --fix

node_modules/@rdfjs/types/index.d.ts:3:1 - error TS1383: Only named exports may use 'export type'.

3 export type * from './data-model';
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@rdfjs/types/index.d.ts:4:1 - error TS1383: Only named exports may use 'export type'.

4 export type * from './stream';
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@rdfjs/types/index.d.ts:5:1 - error TS1383: Only named exports may use 'export type'.

5 export type * from './dataset';
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@rdfjs/types/index.d.ts:6:1 - error TS1383: Only named exports may use 'export type'.

6 export type * from './query';

}
}
Loading