Smoke Test SDK (@W-18482922@)#428
Merged
joeluong-sfcc merged 7 commits intofeature/oasfrom Aug 12, 2025
Merged
Conversation
alexvuong
approved these changes
Aug 12, 2025
vcua-mobify
reviewed
Aug 12, 2025
| if (name === "Shopper Baskets OAS") { | ||
| return version === "v2" ? "ShopperBasketsV2" : "ShopperBasketsV1"; | ||
| if (name === "Shopper Baskets OAS" && version === "v2") { | ||
| return "ShopperBasketsV2"; |
Contributor
There was a problem hiding this comment.
Based on this, I assume we've decided to name shopper baskets V1 as ShopperBaskets and not ShopperBasketsV1?
Collaborator
Author
There was a problem hiding this comment.
Yes that's correct
| * Recursively removes all files ending in '-internal.yaml' from a directory and its subdirectories | ||
| * @param directoryPath - The path to the directory to process | ||
| */ | ||
| export function removeInternalOas(directoryPath: string): void { |
Contributor
There was a problem hiding this comment.
Just curious, do we need to run this more than once? Or is this just a helper function for cleaning up the -internal files current state of the repo?
Collaborator
Author
There was a problem hiding this comment.
We'll have to run it everytime we pull down the APIs as the internal OAS file will always be a part of anypoint exchange asset (at least for now)
vcua-mobify
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR smoke tests the new OAS SDK and adds small updates for any gaps found.
The CI is expected to fail in this PR and will be fixed in a follow up PR to prepare for the release of the SDK. This is because we need to pull in the latest versions of the APIs and I don't want to bloat this PR with all the API changes.
npm run testshould pass after updating the APIsTesting Instructions
git checkout ju/smoke-testnpm run ciANYPOINT_USERNAMEandANYPOINT_PASSWORDto environment variablesnpm run updateApisnpm run buildnpm init -ynpm installnode index.jsin the sample project directory