Skip to content

Commit ce7a3e4

Browse files
committed
Bump all GithubAction workflows to use Node 22
1 parent b926294 commit ce7a3e4

File tree

4 files changed

+20
-28
lines changed

4 files changed

+20
-28
lines changed

.github/workflows/nightly_release.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ jobs:
1212
contents: write
1313
steps:
1414
- name: Checkout
15-
uses: actions/checkout@v3
15+
uses: actions/checkout@v4
1616
with:
1717
fetch-depth: 0
1818

@@ -42,9 +42,9 @@ jobs:
4242
echo "commerce_sdk_react_version_base=$version" >> "$GITHUB_ENV"
4343
4444
- name: Setup Node
45-
uses: actions/setup-node@v3
45+
uses: actions/setup-node@v4
4646
with:
47-
node-version: 18
47+
node-version: 22
4848
cache: npm
4949

5050
- name: Install Monorepo Dependencies

.github/workflows/setup_pwa_manual.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,13 +48,13 @@ jobs:
4848
4949
- name: Checkout
5050
id: checkout
51-
uses: actions/checkout@v3
51+
uses: actions/checkout@v4
5252

5353
- name: Setup node
5454
id: setup_node
5555
uses: actions/setup-node@v4
5656
with:
57-
node-version: 18
57+
node-version: 22
5858
cache: "npm"
5959

6060
- name: Setup PWA dependencies

.github/workflows/setup_template_retail_react_app_manual.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@ jobs:
1919
2020
- name: Checkout
2121
id: checkout
22-
uses: actions/checkout@v3
22+
uses: actions/checkout@v4
2323

2424
- name: Setup node
2525
id: setup_node
2626
uses: actions/setup-node@v4
2727
with:
28-
node-version: 18
28+
node-version: 22
2929
cache: "npm"
3030

3131
- name: Setup PWA dependencies

.github/workflows/test.yml

Lines changed: 13 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -44,30 +44,26 @@ jobs:
4444
strategy:
4545
fail-fast: false
4646
matrix:
47-
node: [16, 18, 20, 22]
47+
node: [18, 20, 22]
4848
npm: [8, 9, 10, 11]
49-
exclude: # node 16 with npm 10/11 and node 18 with npm 11 are not compatible
50-
- node: 16
51-
npm: 10
52-
- node: 16
53-
npm: 11
49+
exclude: # node 18 with npm 11 are not compatible
5450
- node: 18
5551
npm: 11
5652
runs-on: ubuntu-latest
5753
env:
5854
# The "default" npm is the one that ships with a given version of node.
5955
# For more: https://nodejs.org/en/download/releases/
6056
# (We also use this env var for making sure a step runs once for the current node version)
61-
IS_DEFAULT_NPM: ${{ (matrix.node == 16 && matrix.npm == 8) || (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) }}
57+
IS_DEFAULT_NPM: ${{ (matrix.node == 18 && matrix.npm == 10) || (matrix.node == 20 && matrix.npm == 10) || (matrix.node == 22 && matrix.npm == 10) }}
6258
# The current recommended version for Managed Runtime:
6359
# https://developer.salesforce.com/docs/commerce/pwa-kit-managed-runtime/guide/upgrade-node-version.html
6460
IS_MRT_NODE: ${{ matrix.node == 22 && matrix.npm == 10 }}
6561
steps:
6662
- name: Checkout
67-
uses: actions/checkout@v3
63+
uses: actions/checkout@v4
6864

6965
- name: Setup Node
70-
uses: actions/setup-node@v3
66+
uses: actions/setup-node@v4
7167
with:
7268
node-version: ${{ matrix.node }}
7369
cache: npm
@@ -144,13 +140,9 @@ jobs:
144140
strategy:
145141
fail-fast: false
146142
matrix:
147-
node: [16, 18, 20, 22]
143+
node: [18, 20, 22]
148144
npm: [8, 9, 10, 11]
149-
exclude: # node 16 with npm 10/11 and node 18 with npm 11 are not compatible
150-
- node: 16
151-
npm: 10
152-
- node: 16
153-
npm: 11
145+
exclude: # node 18 with npm 11 is not compatible
154146
- node: 18
155147
npm: 11
156148
runs-on: windows-latest
@@ -165,10 +157,10 @@ jobs:
165157
IS_MRT_NODE: ${{ matrix.node == 22 && matrix.npm == 10 }}
166158
steps:
167159
- name: Checkout
168-
uses: actions/checkout@v3
160+
uses: actions/checkout@v4
169161

170162
- name: Setup Node
171-
uses: actions/setup-node@v3
163+
uses: actions/setup-node@v4
172164
with:
173165
node-version: ${{ matrix.node }}
174166
cache: npm
@@ -297,10 +289,10 @@ jobs:
297289
PROJECT_DIR: generated-${{ matrix.template }}
298290
steps:
299291
- name: Checkout
300-
uses: actions/checkout@v3
292+
uses: actions/checkout@v4
301293

302294
- name: Setup Node
303-
uses: actions/setup-node@v3
295+
uses: actions/setup-node@v4
304296
with:
305297
node-version: 22
306298

@@ -350,10 +342,10 @@ jobs:
350342
runs-on: ubuntu-latest
351343
steps:
352344
- name: Checkout
353-
uses: actions/checkout@v3
345+
uses: actions/checkout@v4
354346

355347
- name: Setup Node
356-
uses: actions/setup-node@v3
348+
uses: actions/setup-node@v4
357349
with:
358350
node-version: ${{ matrix.node }}
359351
cache: npm

0 commit comments

Comments
 (0)