Conversation
…into W-16544327-social-login-ui
…orceCommerceCloud/pwa-kit into W-16544327-social-login-ui
…al-login-ui @W-16544327 social login UI
…orceCommerceCloud/pwa-kit into feature-passwordless-social-login
…into feature-passwordless-social-login
…into feature-passwordless-social-login
…into feature-passwordless-social-login
Add wrappers for social login helpers: `authorizeIDP` and `loginIDPUser` --------- Co-authored-by: Joel Uong <88680517+joeluong-sfcc@users.noreply.github.com>
Signed-off-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Signed-off-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Signed-off-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
…2075) * Add `authorizePasswordless` and `getPasswordLessAccessToken` wrappers to `commerce-sdk-react` * Add `callbackURI` to Auth class and `CommerceApiProvider` --------- Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
This PR implements the Social Login redirect page which has a loading state until the user is successfully logged in.
Signed-off-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Signed-off-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
* add StandardLogin, PasswordlessLogin, SocialLogin components
Implement a Check Your Email page that will be used in the passwordless login flow --------- Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
…ge (#2105) Add passwordless/social login UI buttons to the Checkout page if enabled. --------- Signed-off-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com> Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Co-authored-by: Jinsu Ha <j.ha@salesforce.com> Co-authored-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
Signed-off-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
…to UI (#2124) Integrate Social Login UI changes in the PWA Kit to backend SLAS API calls. --------- Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
* make passwordless login work by sending an email via a Marketing Cloud integration * add new check email page * make passwordless login work in auth-modal * create use-passwordless-login hook and support passwordless in /login page * add /passwordless-login-landing page * add /reset-password-landing page * call mergeBasket during passwordless login
…r social/passwordless login & reset password (#2198) Customers can change the callback & redirect uri's for social login, passwordless login, and password reset via env var
|
I think after the latest changes to commerce-sdk-isomophic released, we may still see some tests failing. I've built and copied the commerce-sdk-isomorphic with the latest changes. Then I ran
|
| 'module-resolver', | ||
| { | ||
| 'root': ['./'], | ||
| 'alias': { | ||
| '@salesforce/retail-react-app': './' | ||
| } | ||
| } |
There was a problem hiding this comment.
Cool, thanks for fixing the module-not-found issue.
| // TODO: no code verifier needed with the fix blair has made, delete this when the fix has been merged to production | ||
| // @ts-ignore |
There was a problem hiding this comment.
TODO: Delete this when SLAS has been released!
There was a problem hiding this comment.
@vmarta This RAML change is being published tomorrow, so will not be included in the latest isomorphic release. I will need to add an eslint comment above this so that the lint step does not fail for commerces-sdk-react
There was a problem hiding this comment.
@yunakim714 I've added the eslint ignore comment in the feature branch
…teClientToEndpoints regex
| applySLASPrivateClientToEndpoints: | ||
| /oauth2\/(token|passwordless|password\/(login|token|reset|action))/, | ||
| /oauth2\/(token|authorize|passwordless\/(login|token)|password\/(reset|action))/, |
There was a problem hiding this comment.
Now that we're supporting passwordless login, social login, etc, I think we should have this regex as the default. In other words, the value for applySLASPrivateClientToEndpoints should be in the pwa-kit-runtime and not here in the retail-react-app template.
Having it in the runtime will be an easier change to consume by the customers. Otherwise, how would they know to update their existing project such that it configures the applySLASPrivateClientToEndpoints option?
There was a problem hiding this comment.
@vcua-mobify since you originally wrote the code for applySLASPrivateClientToEndpoints, what should we do in this case? ^
There was a problem hiding this comment.
I agree with @vmarta
applySLASPrivateClientToEndpoints can be overridden by defining a applySLASPrivateClientToEndpoints inside the options object in ssr.js but since these will be a default supported endpoint, let's update the endpoint in the runtime
|
For further commits/changes, can we create a separate PR please? It would be easier to track the changes that way. |
* Remove initial fetch to improve performance and fix bugs
Add DNT to `loginIDPUser` and `getPasswordLessAccessToken` wrappers. Skip Social Login E2E test for now as Playwright cannot get past Google 2FA. --------- Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com>
…ints` (#2250) * Move applySLASPrivateClientToEndpoints to pwa-kit-runtime The change will be easier to consume than if it's in the template. * Authorize endpoint do not need the authorization header Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Signed-off-by: Vincent Marta <vmarta@gmail.com> * Minor cleanup --------- Signed-off-by: Vincent Marta <vmarta@gmail.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com>
7 participants
Description
Types of Changes
Changes
template-retail-react-app/config/default.jsHow to Test-Drive This PR
npm run testincommerce-sdk-reactpackagenpm run testintemplate-retail-react-apppackageChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization