@W-17271709 Passwordless Login in Checkout#2178
Merged
hajinsuha1 merged 119 commits intofeature-passwordless-social-loginfrom Jan 22, 2025
Merged
@W-17271709 Passwordless Login in Checkout#2178hajinsuha1 merged 119 commits intofeature-passwordless-social-loginfrom
hajinsuha1 merged 119 commits intofeature-passwordless-social-loginfrom
Conversation
…k-email-page Signed-off-by: Yuna Kim <84923642+yunakim714@users.noreply.github.com>
…d in with paswordless once
This reverts commit acf5410.
…wordless-poc-mc Signed-off-by: Jinsu Ha <91205717+hajinsuha1@users.noreply.github.com>
…into W-17093012-passwordless-poc-mc
alexvuong
approved these changes
Jan 13, 2025
yunakim714
approved these changes
Jan 14, 2025
|
|
||
| const isIdpValid = (name) => { | ||
| return name in IDP_CONFIG && IDP_CONFIG[name.toLowerCase()] | ||
| const formattedName = name.toLowerCase() |
Collaborator
There was a problem hiding this comment.
Nice I had this in my PR too!
| const submitForm = async (data) => { | ||
| setError(null) | ||
| try { | ||
| if (isPasswordlessLoginClicked) { |
Collaborator
There was a problem hiding this comment.
I think this is okay because in the Auth modal and the Login pages, we also rely on a similar method to differentiate between the login methods.
If you wanted to keep the code consistent, we could use setLoginType as we do in those other login locations as so.
| try { | ||
| if (isPasswordlessLoginClicked) { | ||
| await authorizePasswordlessLogin.mutateAsync({userid: data.email}) | ||
| setAuthModalView(EMAIL_VIEW) |
Collaborator
There was a problem hiding this comment.
Yup seems like we can add an a11y ticket for this... But non-blocking for release!
…dless-login-in-checkout
…dless-login-in-checkout
…ks after failed passwordless
…dless-login-in-checkout
…dless-login-in-checkout
…m:SalesforceCommerceCloud/pwa-kit into W-17271709-passwordless-login-in-checkout
…eCommerceCloud/pwa-kit into W-17458039-handle-error-states
…dless-login-in-checkout
Base automatically changed from
W-17458039-handle-error-states
to
feature-passwordless-social-login
January 22, 2025 14:50
…wordless-login-in-checkout
hajinsuha1
merged commit 1b9aeb5
into
feature-passwordless-social-login
5 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support the passwordless login flow when clicking the "Secure Link" button from the Checkout page.
Types of Changes
Changes
/oauth2/passwordless/loginAPI call when clicking the "Secure Link" button on the Checkout pageHow to Test-Drive This PR
Please enter your email address.error msg is displayedj.haand click "Secure Link" buttonChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization