@W-17594891 Update Wording of Interface In DNT hook#2182
Merged
jeremy-jung1 merged 6 commits intodnt-ui-branchfrom Jan 16, 2025
Merged
@W-17594891 Update Wording of Interface In DNT hook#2182jeremy-jung1 merged 6 commits intodnt-ui-branchfrom
jeremy-jung1 merged 6 commits intodnt-ui-branchfrom
Conversation
alexvuong
approved these changes
Jan 14, 2025
alexvuong
reviewed
Jan 14, 2025
| /** @deprecated - Deprecated since version 3.1.0. Use selectedDoNotTrackValue instead. */ | ||
| selectedDnt, | ||
| effectiveDnt, | ||
| /** @deprecated - Deprecated since version 3.1.0. Use selectedDnt instead. */ |
Contributor
There was a problem hiding this comment.
Please move this block to jsdoc comment so it will be generated into the typedoc when we merge.
alexvuong
reviewed
Jan 14, 2025
| /** @deprecated - Deprecated since version 3.1.0. Use selectedDnt instead. */ | ||
| dntStatus, | ||
| updateDNT | ||
| /** @deprecated - Deprecated since version 3.1.0. Use updateDnt instead. */ |
alexvuong
reviewed
Jan 14, 2025
| updateDNT | ||
| /** @deprecated - Deprecated since version 3.1.0. Use updateDnt instead. */ | ||
| updateDNT, | ||
| updateDnt |
Contributor
There was a problem hiding this comment.
which one are we deprecating again? updateDNT is a defined func, if we remove it, what does updateDnt equal to?
Collaborator
Author
There was a problem hiding this comment.
They are the same thing. We are deprecating updateDNT and dntStatus
jeremy-jung1
changed the title
This was referenced Jan 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Description
Mentioning of
doNotTrackin the wording of the properties returned byuseDNThave been consolidated into 'Dnt', to mirror the acronym wording in 'defaultDnt'. This is to use a more consistent wording in the Dnt feature.Properties that were previously released have been noted for deprecation but were kept in the interface to avoid breaking changes, as discussed offline.
Types of Changes
Changes
How to Test-Drive This PR
dw_dntis 1cquotientin the search. See that no API calls have been made.cquotientAPI calls are now madeChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization